Refactor PTAL embed creation and Add buttons to PTAL response to make it easier to access #3
+69
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreyfus92
previously approved these changes
Jan 17, 2025
louisescher
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
ptalcommand functionality in thesrc/commands/ptal.ts,src/utils/ptal/editPtalMessage.ts, andsrc/utils/ptal/makePtalEmbed.tsfiles. The main updates focus on refactoring themakePtalEmbedfunction to return more comprehensive interaction and edit options, as well as adding new buttons to the embed messages.Refactoring and enhancements:
src/commands/ptal.ts: Updated thehandlerfunction to use the newnewInteractionproperty returned bymakePtalEmbedfor replying to interactions.src/utils/ptal/editPtalMessage.ts: Modified theeditPtalMessagefunction to use the neweditproperty returned bymakePtalEmbedfor editing messages.src/utils/ptal/makePtalEmbed.ts: Added new imports forActionRowBuilder,ButtonBuilder,ButtonStyle,InteractionReplyOptions, andMessageEditOptionsfromdiscord.js.New functionality:
src/utils/ptal/makePtalEmbed.ts: Defined aMakePtalEmbedtype that includesnewInteractionandeditproperties, which are used to handle both new interactions and message edits.src/utils/ptal/makePtalEmbed.ts: Enhanced themakePtalEmbedfunction to include buttons for "See on GitHub" and "View Files" in the embed messages, improving user interaction with pull request notifications.